Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thwomper's Synthetic Uniforms(THWOMP SHRAMALERT) & Synth Vendor QOL #3824

Merged
merged 6 commits into from
Jul 12, 2023

Conversation

QuickLode
Copy link
Contributor

@QuickLode QuickLode commented Jul 6, 2023

About the pull request

Incorporates Thwomper's Synthetic Uniforms & Vest into the game.
(I tried to be creative with the lore but I'm not paid by the hour man! that UA laborer is.)

Synthetic Vendor QOL making it easier to find and use.

Slight moving of stuff, vestigial stuff moved too.

Explain why it's good for the game

THWOMP SHRAMALERT

Gives a UA Colony/Shipside theme.

QOL makes things easier to use.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.
tested and everything appears to be working well(tahts how i got the screenshot)
https://cdn.discordapp.com/attachments/777257424590995466/1126429970244325406/image.png

Changelog

🆑 QuickLoad, Thwomper
imageadd: Synthetic Uniforms & Vest with United Americas flair and classic jumpsuits which remind you of life on the Frontier. Sprited by THE THWOMPA himself!
qol: Synthetic Vendor is more organized. Removes scrub cap, adds shoe.
/:cl:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

You currently have a negative Fix/Feature pull request delta of -12. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

@github-actions github-actions bot added Sprites Remove the soul from the game. Quality of Life Make the game harder to play labels Jul 6, 2023
Copy link
Contributor

@sleepynecrons sleepynecrons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of the outfits look great except for cargo_light. the shading is very flat, lacks contrast and needs a proper outline like the rest of the outfits
image
the jacket tied around the waist is also at inconsistent heights and there is a random pixel on the east/west sprites. the lower half in general needs a re-draw

Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo light looks fixed to me but I'll wait for sleepy to approve too

@nauticall nauticall added Sprites Approved confirmed no stray pixels and removed Sprites Approved confirmed no stray pixels labels Jul 8, 2023
Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mb the shading on the shirt still needs work. shading should be darker round the top and more outlined

@QuickLode
Copy link
Contributor Author

thwompshirtIN!

@thwompa
Copy link
Contributor

thwompa commented Jul 11, 2023

should be GOOD2GO(tm patent pending)

Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now THAT is spriting 💯

@nauticall nauticall added the Sprites Approved confirmed no stray pixels label Jul 11, 2023
Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gouda 🧀

@nauticall nauticall added this pull request to the merge queue Jul 12, 2023
Merged via the queue into cmss13-devs:master with commit 8b00ccc Jul 12, 2023
27 checks passed
cm13-github added a commit that referenced this pull request Jul 12, 2023
github-actions bot added a commit that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants