SMG Gun+Mag Holster #3825
SMG Gun+Mag Holster #3825
Conversation
|
You currently have a negative Fix/Feature pull request delta of -4. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
github-actions
bot
added
Sprites
I considered that at first, that's even how I initially did it, but the way the code works for the sprites is that the gun is placed behind the sprite not in front of it. So I settled on what is currently being used. Outside of a code solution to make the gun sprite appear in front of the rig sprite, which I won't be able to do by myself, I did a hacky fix where I edited the rig sprite to remove the parts of the rig that would be in front of the gun sprite. Not a great solution though. |
|
For the interim I've implemented an alt solution as described above, here is how the sprite looks in game
|
swap the holster and mag pouches position and it'll be good to go |
|
Swapped the sprite around |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
code/game/machinery/vending/vendor_types/intelligence_officer.dm
Outdated
Show resolved
Hide resolved
code/game/machinery/vending/vendor_types/squad_prep/squad_engineer.dm
Outdated
Show resolved
Hide resolved
code/game/machinery/vending/vendor_types/squad_prep/squad_medic.dm
Outdated
Show resolved
Hide resolved
code/game/machinery/vending/vendor_types/squad_prep/squad_specialist.dm
Outdated
Show resolved
Hide resolved
|
Requested changes made. |
cm13-github
added
the
Merge Conflict
cm13-github
removed
the
Merge Conflict
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
gonna make a change |
|
Stated to make this replace the current SMG belt, will need to make some changes, shouldn't take too long (famous last words) |
|
This SMG belt now replaces all regular instances of the old SMG belt. Old SMG belt is still in the game, though I believe only PMC's use it now. |
About the pull request
Adds a new holster for the SMG. It can hold a M39 SMG plus two M39 magazines, it replaces the old SMG belt.
Explain why it's good for the game
The M39 SMG is intended as an inferior firearm to the mainline M41A. The perceived benefit of a M39 would be its lightness compared to the bulkier M41A, however this is not reflected in-game outside of the M39 not confering a movement speed down when wielded, which is shared with many other bulky guns like the M4RA.
The idea around this new holster is that it would give Marines a better reason to consider taking the M39, as Marines in a more support oriented role can access a unique holster that lets them carry additional magazines in addition to the firearm itself.
Testing Photographs and Procedure
Screenshots & Videos
Current iteration
Old iteration
Old sprite and internal storage view
OBJ sprites and the inventory capacity as seen in game
Changelog
🆑
add: The SMG belt has been changed. It now holds a SMG plus two extra magazines, plus it can fit in either the belt or armour slot.
/:cl: