Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increases default window sizes for paper and desc_lore windows #3833

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Increases default window sizes for paper and desc_lore windows #3833

merged 2 commits into from
Jul 19, 2023

Conversation

silencer-pl
Copy link
Contributor

@silencer-pl silencer-pl commented Jul 7, 2023

About the pull request

This PR adjusts the window size for both paper (including faxes) and desc_lore preview windows. Paper previews were made both wider and longer so most custom templates currently used by staff load in immediately. lore_desc is made about twice as longer by default, again to enhance its initial readability and account for the fact that both windows are meant to be text heavy. This was also going to fix desc_lore not interpreting HTML tags properly, but that apparently fixed itself. We can probably safely bet that in the year 2023 people play CM on resolutions greater than 800x600.

Explain why it's good for the game

Both windows were comically too small by default, seemingly both running on the assumption that people still run SS13 in 640x480. This PR makes it so you can read paper and/or lore without having to start each time by resizing your window. Having our default window sizes actually more or less match expected content in the window is a positive all around.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑silencer_pl
qol: Default paper and desc_lore viewing windows are now larger to match the expected content in them better.
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Jul 7, 2023
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 15, 2023
@morrowwolf morrowwolf added this pull request to the merge queue Jul 19, 2023
Merged via the queue into cmss13-devs:master with commit 2b04794 Jul 19, 2023
30 checks passed
cm13-github added a commit that referenced this pull request Jul 19, 2023
github-actions bot added a commit that referenced this pull request Jul 19, 2023
@silencer-pl silencer-pl deleted the literacybuff branch August 19, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants