Adds improvisation traits #3836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You currently have a negative Fix/Feature pull request delta of -15. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
cm13-github
added
the
Merge Conflict
cm13-github
removed
the
Merge Conflict
morrowwolf
suggested changes
Jul 19, 2023
| @@ -111,8 +112,8 @@ affected_limb, or location vars. Also, in that case there may be a wait between | |||
| for(var/obj/surface in get_turf(target)) //Otherwise, get the lowest surface modifier of objects on their turf. | |||
| if(surface_modifier > surface.surgery_duration_multiplier) | |||
| surface_modifier = surface.surgery_duration_multiplier | |||
|
|
|||
| step_duration *= surface_modifier | |||
| if(!(HAS_TRAIT(user, TRAIT_FASTLEARNER))) | |||
| @@ -102,7 +102,8 @@ affected_limb, or location vars. Also, in that case there may be a wait between | |||
|
|
|||
| if(ispath(tool_type)) //Tool speed modifier. This means hand & any item are 100% efficient as surgical tools. | |||
| tool_modifier = tools[tool_type] | |||
| step_duration *= tool_modifier | |||
| if(!(HAS_TRAIT(user, TRAIT_IMPROVISER))) | |||
| step_duration *= tool_modifier | |||
There was a problem hiding this comment.
Just half the malus rather than completely remove it, regular tools should still be better
|
Renegged on agreed end-result prior to starting work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Adds a new skill for survivor doctor/synthetic roles, surgical improvisation. The skill removes penalty for using improvised/substitute tools and can reduce penalty for working on poor surfaces at mastery.
Explain why it's good for the game
Helps improve some of the gameplay experience of the survivor synthetic, and also adds a reason to take survivor doctor instead of researcher, since without this the researcher is simply better. Also, FORECON support tech gets the skill because it is soulful that a recon marine, who is expected to be more motivated/skilled, can do IB repair a little faster in the middle of nowhere.
Testing Photographs and Procedure
Tested on a private lobby to make sure it runs without breaking things and works as intended. Tested by spawning a survivor synthetic and a CMO, and having them do ribcage opening/closing/sawing on an OR table and rollerbed, and comparing times vs the expected times in code.
Changelog
🆑
add: New trait, surgical improvisation
/:cl: