Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donator Kits #3850

Merged
merged 5 commits into from
Jul 20, 2023
Merged

Donator Kits #3850

merged 5 commits into from
Jul 20, 2023

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Jul 10, 2023

About the pull request

Changes all existing donator gear to spawn inside boxes rather than dumping items into a donator's inventory.
Kits cannot be opened unless by the donator, and can be destroyed with a right-click by the donator.

Also tidied many of the typepaths that were confusing to make it easier to understand what the item is.

Explain why it's good for the game

Makes things tidier.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Added donator kit boxes that hold a donator's special gear. They can be destroyed with a right-click while on the ground, and are locked to the donator.
code: Tidied up typepaths for many donator items to make it clearer what or who they are for.
code: Removed the requirement for donators to match their character name to our config file.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge Code Improvement Make the code longer labels Jul 10, 2023
Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crate sprite needs a thicker, darker outline to match CM spriting standards. I know this is a donor item that nowadays has a 1 in 100 chance of being found in the wild but as they say, give an inch they'll take a mile.

I would recommend making the sprite, first of all, symmetrical (it isn't) and then darkening the outlines significantly so that they stand out against the backdrop.You could probably lighten the outline too towards the top to match the shading.
I like the color palette though.

@harryob harryob added this pull request to the merge queue Jul 20, 2023
Merged via the queue into cmss13-devs:master with commit b2d038e Jul 20, 2023
27 checks passed
github-actions bot added a commit that referenced this pull request Jul 20, 2023
cm13-github added a commit that referenced this pull request Jul 20, 2023
@realforest2001 realforest2001 deleted the forest/donortweaks branch July 20, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Feature Feature coder badge Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants