Synthetic Gas fixes #3858
Synthetic Gas fixes #3858
Conversation
|
You currently have a negative Fix/Feature pull request delta of -1. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
| @@ -132,6 +132,8 @@ | |||
|
|
|||
| /obj/effect/particle_effect/smoke/bad/affect(mob/living/carbon/M) | |||
| ..() | |||
| if (isxeno(M) || isyautja(M) || issynth(M)) | |||
There was a problem hiding this comment.
Smoke is more than just inhalation but also disorientation from senses being obscured. Synths should not cough yes but losing what they're holding/dragging is reasonable and part of gameplay considerations for smoke. (The same with the other two as well)
Essentially, feel free to stop them from coughing. The rest is overreach if we're calling it a "bug".
| @@ -365,7 +367,7 @@ | |||
|
|
|||
| /obj/effect/particle_effect/smoke/xeno_weak/affect(mob/living/carbon/moob) // This applies every tick someone is in the smoke | |||
| ..() | |||
| if(isxeno(moob)) | |||
| if(isxeno(moob) || issynth(moob)) | |||
There was a problem hiding this comment.
Either find a different way to effect them or remove this. This is another gameplay consideration.
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
Synthetics are no longer effected by boiler's neurotoxin gas
Synth, xenos and predators no longer drop items and cough in normal smoke
Explain why it's good for the game
Robot beep boops, ignores neurotoxins,
Smoke dropping LRP for non-humans
Changelog
🆑 ghostsheet
fix: Synthetics are no longer affect by neurotoxin gas.
fix: Synthetics, Predators and Xenos are no longer affect by regular smoke.
/:cl: