3rd Party Victory Music (WY, UPP, CLF, USCM) #3861
Conversation
github-actions
bot
added
Sound
normalized to -8db
|
Forgot to normalize the new files to -8db, special shoutout to Thwomp for saving countless eardrums. Reuploaded new oggs. |
Co-authored-by: Ben <[email protected]>
Co-authored-by: Ben <[email protected]>
|
noice, now the other major factions have music for if any HVH events occur |
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
|
The WY one is great. The CLF and UPP ones could have better songs, though. My main issue with the UPP is that it's maybe a bit too much? Don't get me wrong, the Sacred War is a Real Soviet Classic (tm) but it doesn't feel quite right; A little too high energy if you feel me. Personally I believe this song might fit better: |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
code/game/gamemodes/cm_process.dm
Outdated
| num_headcount++ | ||
| continue | ||
| num_headcount++ | ||
| return list(num_marines,num_WY,num_UPP,num_CLF,num_headcount) |
There was a problem hiding this comment.
make this an associated list so we're not accessing by index later
| if(living_player_list[1] && !living_player_list[2]) // If Xeno Minor but Xenos are dead and Humans are alive, see which faction is the last standing | ||
| var/headcount = count_per_faction() | ||
| var/living = headcount[5] | ||
| if ((headcount[2] / living) > MAJORITY) // headcount[2] = Weyland-Yutani |
There was a problem hiding this comment.
see above about accessing by index
|
Made the headcount tally and associative list! |
Co-authored-by: harryob <[email protected]>
|
Your Fix/Feature pull request is currently below zero (-4). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score. |
About the pull request
This adds a "Last Man Standing" condition, where in the event of a Xeno Minor where all Xenos are dead but humans are still in control of the ship, we figure out which faction controls the Almayer and play thematic music for that faction. Currently whichever faction has more than 50% of the Last Troops Standing, is considered the "winner". Additionally the Colonial Marines theme song is now officially the USCM hijack comeback song.
Melancholy1 is the fallback in the case that there is no determined majority.
This adds:
Note: This only alters what music plays during a Xeno Minor. The round outcome still counts as a Xeno win both mechanically and statistically.
Explain why it's good for the game
In the rare event of a botched xeno hijack, it'd be cool to do something special if a 3rd party manages to secure a USCM Warship.
Testing Photographs and Procedure
The headcount proc was tested against ERT members making sure that faction count was accurate.
The music selector was tested by forcing round_status to Xeno_Minor and verifying that we toggle between whomever is the majority.
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
add: Added unique, faction dependent music to Round End in the event that Xenos lose post hijack.
/:cl: