-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New UPP guns #3865
Merged
Merged
New UPP guns #3865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithout committing it
You currently have a negative Fix/Feature pull request delta of -9. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
github-actions
bot
added
Sprites
Remove the soul from the game.
Mapping
did you remember to save in tgm format?
Sound
Blast 5 minutes of bass boosted music to our players
Feature
Feature coder badge
Removal
snap
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
Fix
Fix one bug, make ten more
Grammar and Formatting
Fixes the codebase's tpyos and grammatical's errors
labels
Jul 11, 2023
Could you elaborate on what this was?
|
I forgot to remove the default CL for QOL |
cm13-github
added
the
Merge Conflict
PR can't be merged because it touched too much code
label
Jul 16, 2023
3 tasks
3 tasks
3 tasks
Zonespace27
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
Feature
Feature coder badge
Fix
Fix one bug, make ten more
Grammar and Formatting
Fixes the codebase's tpyos and grammatical's errors
Mapping Approved
adds 500 new dict keys
Mapping
did you remember to save in tgm format?
Removal
snap
Sound
Blast 5 minutes of bass boosted music to our players
Sprites Approved
confirmed no stray pixels
Sprites
Remove the soul from the game.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Adds a bunch of new UPP guns to replace ill-fitting ones, respites others, removes others, also does some balance changes that I feel would be good for the game, nothing too outrageous I believe.
All sprites by wei/esselnek
lore and stuff
Look at changelog and code for specific changes unless i get asked by a dev to list them here
Explain why it's good for the game
New UPP guns to replace old things that don't make sense, better sprites, IMO needed balance changes.
Testing Photographs and Procedure
Slightly outdated and I forgot Type 23, but mostly correct. Look at imagediff for type 23 sprite
Changelog
I might have forgotten a thing or two since I've been working on this on and off since April, but from what I can tell mostly there
🆑
add: Adds 6(8 if you're pedantic) new guns for the UPP, details for each in following lines.
add: Type 19, Replacement for PPsh on colonies and black market.
add: Type 64, replacement for scorpion, full sized SMG, 2 versions, 1 for upp, 1 for not upp
add: HJRA-12, RPG for UPP.
add: Type 73, pistol for higher ranked UPP troops, UPP COs get a Type 74 which has high-impact rounds, replaces PK9 in non-UPP use.
add: NP92, pistol, replaces PK9 in UPP use(mostly), integrally suppressed version called NPZ92 for UPP Commandos.
add: QYJ-72, UPP GPMG, replaces minigun with UPP Minigunners
add: Technically resprites but due to changes closer to replaces N-Y revolver with ZHNK-72
add: Adds a character custom loadout Type 73, 2 mags spare.
add: UPP helmets now work as ear protection, intended use with HJRA-12 RPG
add: UPP officers now have regular UM4 helmets instead of UH7 helmets in their vendors as UH7 looked ugly with their combat gear
del: Removes the PK9 entirely
del: Removes tranqs from UPP Commando loadout
del: Removes HEAP ammo from UPP officers and commandos, replaced with normal and AP mags when applicable
balance: UPP jackets no longer have massive armor, in exchange they no longer slow and in clothing vendors a light version of UPP armor is vendable
balance: UPP MPs are now armed with a ZHNK-72 belt on their jacket, with an additional shrapnelshot loader in their belt.
balance: Rebalances Type 71 damage/firerate/AP to be a sidegrade of M41A, about equal DPS, higher damage per shot and AP, lower fire rate, carbine is round-about the exact same as M41A however.
balance: Fixes UPP support armor, given to medics on their person and officers in their vendor, lighter version of UPP armor, exchanges protection for speed.
balance: Seperates SVD bullet damage from crude rifle bullet and buffs it as a hard-hitting AP bullet.
balance: Rebalances UPP revolver(now ZHNK-72), much harder hitting and has higher AP, but rarer, shrapnelshot extremely rare and good.
balance: Due to ammo changes, SVD no longer has burst.
balance: Removes ceramic plates from UPP loadouts
fix: UPP Major now has the correct UPP Commander skillset
fix: UPP Commander skillset can BE
fix: Fixes typepath for UPP support/light armor, actually works now.
spellcheck: Renames SVD to Type 88
spellcheck: Renames UPP Minigunner to UPP Machinegunner
spellcheck: Renames UPP jackets to UL4 all around
soundadd: Adds firing sounds for Type 73 and SVD/UPP MG
imageadd: Resprites the SVD, Type 71, and Type 23, all sprites by wei/esselnek
imageadd: Adds sprites for all above guns, all sprites by wei/esselnek
maptweak: Changes instances of skorpion to non-upp type 64, also changes instances of ppsh to type 19
/:cl: