Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sprites for comtechs #3872

Closed
wants to merge 4 commits into from

Conversation

Dorodomki
Copy link
Contributor

@Dorodomki Dorodomki commented Jul 12, 2023

adds an new helmet design for the comtechs, is an new early sprite in development with probable changes, not so important

About the pull request

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Added something
del: Removed old things
qol: made something easier to use
balance: rebalanced something
fix: fixed a few things
spellcheck: fixed a few typos
ui: changed something relating to user interfaces
code: changed some code
refactor: refactored some code
soundadd: added a new sound thingy
sounddel: removed an old sound thingy
imageadd: added some icons and images
imagedel: deleted some icons and images
mapadd: added a new map or section to a map
maptweak: tweaked a map
config: changed some config setting
admin: messed with admin stuff
server: something server ops should know
/:cl:

adds an new helmet design for the comtechs, is an new early sprite in development with probable changes, not so important
@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Jul 12, 2023
@Zonespace27 Zonespace27 marked this pull request as draft July 13, 2023 10:00
@mullenpaul
Copy link
Contributor

Could you add images and fill out the pull request template?

@Dorodomki
Copy link
Contributor Author

Captura de pantalla (299)
Captura de pantalla (298)

@Dorodomki
Copy link
Contributor Author

Could you add images and fill out the pull request template?

done

Dorodomki and others added 3 commits July 20, 2023 03:36
makes the webbing be able to hold more things to be more useful in the forecon survivor spawn (i literally copy pasted the allowed list of the hazard vests and they are way better than use a webbing wich can't be used to store a gun)
adds a welder chestrig with the same characteristics of the welder satchel to the MT's, i need some help with code it for the marines and add it to the engineering vendors/marinevends
@Dorodomki Dorodomki marked this pull request as ready for review July 23, 2023 03:09
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 24, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix your changelog and PR description as asked originally.
image

Also see: #3984 (comment)

Also aren't most of these changes redudnant to your other PR #3984 ? Only open one PR for the same feature. There appear to be other sprite files in this PR not present in that PR though, so you could have the helmet handled in this PR, or close this PR and add the helmet to that PR.

@Drulikar Drulikar marked this pull request as draft July 25, 2023 01:14
@Dorodomki Dorodomki closed this Jul 27, 2023
@Dorodomki Dorodomki deleted the Dromki-addings branch July 27, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Merge Conflict PR can't be merged because it touched too much code Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants