Revive tableflip fixes #3882
Merged
Revive tableflip fixes #3882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Jul 14, 2023
cm13-github
added a commit
that referenced
this pull request
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR revives #3740 and applies my suggested changes to that PR preventing T and cross shaped table flips.
Explain why it's good for the game
Fixes a game ending exploit, and also gives a bit more sanity to table flipping.
Testing Photographs and Procedure
Screenshots & Videos
Old testing:
This cannot be flipped now:
But this can from the checkmark locations:
Changelog
🆑 Drathek, Fira
fix: Fixed an issue with table flips that could make some tables incorrectly unflippable, and cause infinite loops. It is no longer possible to flip tables that t-shape or cross, or spans more than 5 tiles away from you.
/:cl: