Hard delete fixes for predator landmarks and van if their area changes #3883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
added
the
Hard Deletes
harryob
approved these changes
Jul 15, 2023
cm13-github
added a commit
that referenced
this pull request
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR applies the fixes previously suggested for #3671. That PR was originally replacing much of the colony in a nightmare insert and it exposed how predator landmarks do not handle their area being changed and an issue with the van being replaced. The description made for these landmarks is based on some area information and that is used to index them. This PR makes it so the description of the landmark is saved so it can still be found in the list even if the area changes.
Explain why it's good for the game
Less hard deletes and more futureproofing.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑 Drathek, Steelpoint
fix: Fixed possible hardeletes for predator landmarks and vehicles. Predator teleporation descriptions now do not change if the area is altered at runtime so they can still be found correctly.
/:cl: