Knife webbing fixes and consistency #3899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Feature
harryob
requested changes
Jul 15, 2023
harryob
approved these changes
Jul 20, 2023
cm13-github
added a commit
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR:
Adds sounds for inserting and removing knifes to the knife webbing
Adds draw delay for knives to the knife webbing
Allows using quickdraw with the knife webbing
Standardizes knife draw delay in a define
Knife webbing is now spawned full
Allows knife webbing to be alt-clicked to draw from it
Reviewer notes:
The gun helper stuff looks weird to me. I don't think we ever have to iterate through internal directly from a mob's accessories var but there may be some snowflake stuff going on. Happy to move things around but leaving just in case. (Also looks out of scope :D)
Explain why it's good for the game
Consistency and usability good. I genuinely have no clue how I ended up in this rabbit hole.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑 Morrow
add: Added sounds for inserting and removing knifes to the knife webbing
add: Added draw delay for knives to the knife webbing
add: Allowed using quickdraw with the knife webbing
add: Allowed knife webbing to be alt-clicked to draw from it
add: Knife webbing is now spawned full
code: Standardized knife draw delay in a define
/:cl: