Added preference to disallow de-activation of your current ability #3904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Jul 18, 2023
cm13-github
added a commit
that referenced
this pull request
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR adds a xeno preference where you can disallow the deactivation of your currently selected ability when re-selecting it again. The default state of this toggle will still allow ability deactivation since that is the old behavior.
Locally testing no preferences seem to save so I couldn't confirm that was working correctly; but I did not introduce a new field to be saved, just added to the existing one. Maybe they require a DB?
Explain why it's good for the game
This can help xeno players not accidentally deactivate an ability if they have no need to deactivate an ability. Generally it should be the case there is no need to, but maybe someone has multi-binded MMB or wants to still examine with shift click (if they use shift click preference).
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑 Drathek
qol: Added a preference to disable xeno ability deactivation when re-selecting the same ability
/:cl: