Bump 515 alternate test to 1610 #3925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Github
harryob
approved these changes
Jul 18, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 22, 2023
# About the pull request This PR updates rust_g to https://github.com/tgstation/rust-g/releases/tag/2.1.0 Feel free to request the other ubuntu changes reverted (I just bumped all - at a minimum run_unit_tests.yml needs a newer ubuntu version because of missing libraries libssl and libcrypto). # Explain why it's good for the game ~~Potentially may fix the byond crash on live during `rustg_log_write(GLOB.world_game_log, "ADMIN: [text]", "true")` but I would expect the alternate 515.1609 unit test to break in #3925 but it passes...~~ (That issue may actually just be 1609 breaking call_ext support. See https://www.byond.com/forum/post/2880096) All the changes from tgstation/rust-g@1.2.0...2.1.0 # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: Drathek code: Bump rust_g to 2.1.0 and bump all github testing ubuntu versions to latest. /:cl:
|
Will bump to 1610 once that is released and we swap to it. |
Drulikar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Now that 515.1609 is finally not a closed beta, this test can now be bumped finally to a version we are using on the live server. Now 515.1610 since 1609 was busted.
Explain why it's good for the game
Testing should best replicate what is being used on the live server.
Testing Photographs and Procedure
See checks.
Changelog
🆑 Drathek
code: Bump alternate 515 testing to byond 1610
/:cl: