Fix the M56D ignoring collision when dismounting the user #3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the force move into a move proc that checks for collision.
Made move into step
This reverts commit 01e144d.
|
(Revert was needed I was checking the changes between step and move because gitlens showed the original used step instead of move.) And it seems move should be used but correct me if I am wrong. |
Drulikar
changed the title
Drulikar
approved these changes
Jul 19, 2023
cm13-github
added a commit
that referenced
this pull request
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes #3926
It used a force move to dismount from the gun causing these issues. Now, if you can exit behind you will exit behind the gun.
Explain why it's good for the game
You could exit into turfs with a density of 1 using this. And you should not be able to.
Testing Photographs and Procedure
Screenshots & Videos
Testing it. With cades and a window frame. To ensure it works.
https://imgur.com/a/eT2LBjW
Changelog
🆑
fix: The M56D no longer let's you violate density code when exiting it.
/:cl: