Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental: Bump rust_g to 2.1.0 #3931

Merged
merged 7 commits into from
Jul 22, 2023
Merged

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Jul 19, 2023

About the pull request

This PR updates rust_g to https://github.com/tgstation/rust-g/releases/tag/2.1.0

Feel free to request the other ubuntu changes reverted (I just bumped all - at a minimum run_unit_tests.yml needs a newer ubuntu version because of missing libraries libssl and libcrypto).

Explain why it's good for the game

Potentially may fix the byond crash on live during rustg_log_write(GLOB.world_game_log, "ADMIN: [text]", "true") but I would expect the alternate 515.1609 unit test to break in #3925 but it passes...
(That issue may actually just be 1609 breaking call_ext support. See https://www.byond.com/forum/post/2880096)

All the changes from tgstation/rust-g@1.2.0...2.1.0

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Drathek
code: Bump rust_g to 2.1.0 and bump all github testing ubuntu versions to latest.
/:cl:

@github-actions github-actions bot added the Code Improvement Make the code longer label Jul 19, 2023
@Drulikar
Copy link
Contributor Author

Temporarily testing the test bump to 1609; will revert it after checks finish.

@Drulikar Drulikar marked this pull request as ready for review July 19, 2023 05:38
@harryob harryob added this pull request to the merge queue Jul 22, 2023
Merged via the queue into cmss13-devs:master with commit 0a06835 Jul 22, 2023
27 checks passed
github-actions bot added a commit that referenced this pull request Jul 22, 2023
cm13-github added a commit that referenced this pull request Jul 22, 2023
@Drulikar Drulikar deleted the Bump_RustG_210 branch July 23, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants