Fixes doubling of gadget points for second+ synth #3936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You currently have a negative Fix/Feature pull request delta of -15. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
|
Shouldn't it be condensed to available_points = 45 |
harryob
approved these changes
Jul 24, 2023
cm13-github
added a commit
that referenced
this pull request
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes a bug where if any synthetic that joins will get 45 extra gadget points more than the previous, so 2nd synthetic gets 90 points, 3rd would have 135, and so on. Tested in a private server and working properly.
Explain why it's good for the game
Makes it so late join synthetics or additional joins from events don't get massive gadget budget to spend on like 3 compact defibrillators or start taking things to hand out to marines.
Testing Photographs and Procedure
Went into private server running the branch, spawned 3 shipside USCM synthetics. Sequentially vended the coin, then took 3 gadgets, then did the same with the next. Pre-patch this would result in the 2nd and 3rd synthetics getting huge point budgets, with this patch correctly only gave 45 points to each synthetic.
Changelog
🆑
fix: Fixed synthetics getting an extra 45 points more than any previous who had used the gadget vendor
/:cl: