Facehuggers now bypass time of death checks when joining as Larva #3940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Feature
Drulikar
requested changes
Jul 19, 2023
There was a problem hiding this comment.
You likely also want to change the same check in /mob/living/proc/do_ghost(): https://github.com/cmss13-devs/cmss13/pull/3940/files#diff-08897ff01ebb08d739f4a3e87da529ac87080df7a6bfbe17fdfd85d5a2e5b401L417 Unless you want ghosting to have the same effect; not just death.
Co-authored-by: Drathek <[email protected]>
|
Thanks for heads up regarding ghosting. |
Drulikar
approved these changes
Jul 19, 2023
cm13-github
added a commit
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Facehuggers
(and other ghost roles? (#3939))[this functionality will have to be added in said PR] now bypass the five minute time of death check, letting them join as a larva via queue or.. join as larva button.Explain why it's good for the game
With infection timer at 7.5 minutes, this means that after you die as facehugger, a large portion of the infection time is spent as unjoinable, which isnt a problem for a host YOU infected, but for others, you would get skipped over due to time of death. This allows for more leniency when playing as low-survivablity ghost roles.
Code added can also be expanded, I am sure the new variable can fit in other places.
Changelog
🆑
add: Facehuggers now bypass time of death checks when being considered for larva.
code: new variable for observers to handle bypass of time of death checks
/:cl: