Fix the first prompt to ghost when nested #3943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that would assign a queue time.
harryob
approved these changes
Jul 21, 2023
cm13-github
added a commit
that referenced
this pull request
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR fixes an oversight where the initial prompt to ghost when nested performed ghosting a different way than the ghost verb. Not only does it now use a TGUI prompt, but the larva queue time will be assigned to the time they ghosted so they aren't immediately a candidate (the get_xeno_candidates proc is checking reviveability, but they have no TOD yet so it skipped that check for nested).
An alternative implementation to this would be to have that proc account for nested, but I was more inclined to do this this way to update the prompt to tgui.
Explain why it's good for the game
More TGUI usage for user prompts, and nested marines should not get prioritized in the larva queue.
Testing Photographs and Procedure
Screenshots & Videos
https://youtu.be/FZTtlhTQPbE
Changelog
🆑 Drathek
fix: Fixed the prompt when nested to ghost: Now uses a TGUI prompt and sets larva queue time.
/:cl: