Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New blood bags #3961

Merged
merged 4 commits into from
Jul 22, 2023
Merged

New blood bags #3961

merged 4 commits into from
Jul 22, 2023

Conversation

nauticall
Copy link
Contributor

@nauticall nauticall commented Jul 21, 2023

About the pull request

Since we're putting so much emphasis on blood bags lately, I figured I might as well do my part as spriter and add actual labels to the things so you can tell what they are at a glance. Also overhauled the system to use overlays and underlays instead of the cursed full/half/empty thing that it had going beforehand.

Explain why it's good for the game

You now no longer have to manually inspect blood bags to tell what type they are! Rejoice.

Testing Photographs and Procedure

image

Blood bags in action. Sort of. Yes, they actually change color now.

image

Icon states! Also sprinkled in some yet-unused labels for future use(TM). AB types are here, too, because I forgot they weren't in the game.

Changelog

🆑 nauticall
imageadd: Resprited blood bags to look nicer and use proper a proper overlay/underlay system. Their types are also now distinguishable at a glance.
code: Reworked the way blood bag sprites work behind the scenes to use the overlay/underlay system.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Code Improvement Make the code longer labels Jul 21, 2023
Copy link
Contributor

@FransFeiffer FransFeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sprote good, LGTM

@FransFeiffer FransFeiffer added the Sprites Approved confirmed no stray pixels label Jul 21, 2023
@morrowwolf morrowwolf added this pull request to the merge queue Jul 22, 2023
Merged via the queue into cmss13-devs:master with commit 1d28964 Jul 22, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Jul 22, 2023
github-actions bot added a commit that referenced this pull request Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants