-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating MP and warden vendors. adding handgun case. #4007
updating MP and warden vendors. adding handgun case. #4007
Conversation
case isntead of full belt.
...Being basically an engineer, you need to think on how the changes you make can be useful, not only for you, but for the rest of the people who is going to use it. I say that because...you completely replaced the handgun belts because you "thought They were more pleasing to use"? What for the people who used to use them? |
I beg your pardon, but I believe you incorrectly used the word "replace", then. |
i specify after that i added more choice for belt and pouches after. |
ask me if you want CMP to have access to a more rare handgun... |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
indentation
github suck to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, i have some issues w/ this allowing MPs to be less recognizable
code/game/machinery/vending/vendor_types/crew/senior_officers.dm
Outdated
Show resolved
Hide resolved
should be fine now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits
Wrong case to Case Co-authored-by: Zonespace <[email protected]>
i forgot to recheck this file sorry. |
thanks zonespace |
About the pull request
So the idea is to update the vendors for MP and warden because they are outdated.
i replace the full belt by a handgun case choice as i found them more pleasing to use.
i added a bunch of option for pouches and belt(including the previous available handgun belt but empty) that seem fitting to me
Explain why it's good for the game
It expand the option MP and Warden when they equip at start of the game.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
add: Update the MP and Warden vendor to fallow more the standard of the rifleman vendor.
add: change the selection of the handgun from a full belt to a handgun case(3magazin,one railgunlight and the gun.).
/:cl: