-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades the External Webbing #4027
Conversation
Makes the External Webbing work like an Hazard vest for storage, Removes the item from the Staff Officers Locker because morrow wanted (?)
@@ -287,11 +287,11 @@ | |||
/obj/item/device/radio, | |||
/obj/item/tool/crowbar, | |||
/obj/item/tool/crew_monitor, | |||
/obj/item/tool/pen, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you haven't added stuff to this list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also update your changelog to not be the default template
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
# About the pull request <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> saw and this revives idea of #3983 #4027 - removes ext webbing from staff officers(Morrow request) - allows ext webbing to hold belts and firearm - jackets that can hold machete scabbard can hold katana scabbard. not dutch because dutch is for dutch # Explain why it's good for the game pr no longer stale Webbings are made to hold things such as holsters, pouches, or indeed even slinging your firearm. It shouldn't prevent you from holding a firearm. For balancing purposes Morrow would like SO Lockers to not hold this ext webbing which makes sense. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: add: Allows ext webbing to hold firearms. fix: exosuits which can hold scabbards can hold similar scabbards(ie, machete and katana) del: Removes ext webbing from SO Locker /:cl:
Makes the External Webbing work like an Hazard vest for storage, Removes the item from the Staff Officers Locker because morrow wanted (?)
About the pull request
Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
add: Added something
del: Removed old things
qol: made something easier to use
balance: rebalanced something
fix: fixed a few things
spellcheck: fixed a few typos
ui: changed something relating to user interfaces
code: changed some code
refactor: refactored some code
soundadd: added a new sound thingy
sounddel: removed an old sound thingy
imageadd: added some icons and images
imagedel: deleted some icons and images
mapadd: added a new map or section to a map
maptweak: tweaked a map
config: changed some config setting
admin: messed with admin stuff
server: something server ops should know
/:cl: