Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix banishing huggers and lesser drones #4031

Merged
merged 2 commits into from
Jul 29, 2023

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Jul 28, 2023

About the pull request

This PR makes it so huggers and lesser drones cannot join a hive they are currently banished from.

Explain why it's good for the game

Rejoining as a different mob should not circumvent banishment.

Testing Photographs and Procedure

Screenshots & Videos

image

Changelog

🆑 Drathek
fix: Fix joining as facehugger or lesser drone not checking banishment.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jul 28, 2023
@harryob harryob added this pull request to the merge queue Jul 29, 2023
Merged via the queue into cmss13-devs:master with commit 5ee56c3 Jul 29, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Jul 29, 2023
@Drulikar Drulikar deleted the Fix_Banishing_Huggers_Lessers branch July 29, 2023 06:31
github-merge-queue bot pushed a commit that referenced this pull request Jul 30, 2023
# About the pull request

This PR is a followup to #4031 where I found that ctrl clicking an afk
xeno is also a method to join as a xeno. Now this method also checks for
banishment.

# Explain why it's good for the game

Rejoining as a different mob should not circumvent banishment.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![image](https://github.com/cmss13-devs/cmss13/assets/76988376/2bed0b6a-b3e6-498b-a7f7-c18bfd48eb6e)

</details>


# Changelog
:cl: Drathek
fix: Fixed ctrl+click joining as an afk xeno not checking banishment
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants