Yautja Legacy restoration & Yautja Sprite Fixes #4033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Sprites
Closed
Zonespace27
reviewed
Aug 8, 2023
realforest2001
commented
Aug 8, 2023
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Zonespace27
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Removes duplicate plasma pistol and thwei sprites.
Renamed one of the legacy mask sprites to what it was supposed to be. Renamed the health analyzer for preds from Tracker to scanner.
Changed relay beacon to a newer sprite we never used.
Fixes the code for selecting what used to be "elder" armor. Locked it off to the keys that had that gear.
Explain why it's good for the game
Cleaning out duplicate sprites and old ones is useful I think.
Fixed the legacy gear as we still held the sprites and ~half the code, so might as well make it work as we do have at least one of the users still around.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Tested that it works.
Changelog
🆑
add: Added a preference for using the old legacy yautja armor, only accessible to the people who had the special gear.
fix: Fixed the old Yautja Legacy armor selection code. Removed the unique titles from the legacy gear however.
imageadd: Changed the Yautja relay beacon sprite to a newer unused sprite. Changed iconstate name of health scanner for preds from tracker to scanner.
imageadd: Moved some of the used sprites out of the unused category in pred_gear.dmi.
imagedel: Deleted old relay beacon sprite, deleted duplicate plasma pistol and thwei sprites.
/:cl: