-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yautja Vision Changes #4046
Merged
BeagleGaming1
merged 8 commits into
cmss13-devs:master
from
realforest2001:forest/pred/vision
Aug 12, 2023
Merged
Yautja Vision Changes #4046
BeagleGaming1
merged 8 commits into
cmss13-devs:master
from
realforest2001:forest/pred/vision
Aug 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realforest2001
added
Whitelist Changes
Testmerge Candidate
we'll test this while you're asleep and the server has 10 players
labels
Jul 29, 2023
github-actions
bot
added
Fix
Fix one bug, make ten more
Feature
Feature coder badge
Removal
snap
labels
Jul 29, 2023
3 tasks
3 tasks
Closed
harryob
requested changes
Aug 4, 2023
Co-authored-by: harryob <[email protected]>
realforest2001
force-pushed
the
forest/pred/vision
branch
from
August 10, 2023 14:20
ae3e567
to
10f946d
Compare
BeagleGaming1
requested changes
Aug 12, 2023
BeagleGaming1
approved these changes
Aug 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature
Feature coder badge
Fix
Fix one bug, make ten more
Removal
snap
Testmerge Candidate
we'll test this while you're asleep and the server has 10 players
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This change alters Yautja to fit with the lore on our wiki, giving them natural thermal vision, and a weak night vision capability. To counterbalance this, in order to see clearer with the normal NVGs (which also allow to see the turfs behind other walls), a 5 charge per process fee must be paid, which when operating on the colony results in no natural recharge unless visor is disabled.
I have removed the termal and meson views from the clan mask, as meson was obsolete already and thermal now integrated with species. In doing said integration I have also added a var so different species can have differing inherent sight flags.
I've also updated the checks on the mask for using the visor, as previously you could not change visor setting without bracer, but you could keep the setting of a stolen mask without a bracer.
Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
fix: Picking up a Yautja mask now correctly checks for bracers to apply the visor.
add: Added backend for species datums to hold inherent vision flags.
add: Added proc for Yautja mask to pass power drain back to bracers. Added small power drain on use of mask visor.
add: Added natural thermal vision and very weak night vision to Yautja species, to fit with our wiki lore.
del: Removed Thermal and Meson visors from Yautja mask.
/:cl: