Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yautja Vision Changes #4046

Merged
merged 8 commits into from
Aug 12, 2023

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Jul 29, 2023

About the pull request

This change alters Yautja to fit with the lore on our wiki, giving them natural thermal vision, and a weak night vision capability. To counterbalance this, in order to see clearer with the normal NVGs (which also allow to see the turfs behind other walls), a 5 charge per process fee must be paid, which when operating on the colony results in no natural recharge unless visor is disabled.
I have removed the termal and meson views from the clan mask, as meson was obsolete already and thermal now integrated with species. In doing said integration I have also added a var so different species can have differing inherent sight flags.
I've also updated the checks on the mask for using the visor, as previously you could not change visor setting without bracer, but you could keep the setting of a stolen mask without a bracer.

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: Picking up a Yautja mask now correctly checks for bracers to apply the visor.
add: Added backend for species datums to hold inherent vision flags.
add: Added proc for Yautja mask to pass power drain back to bracers. Added small power drain on use of mask visor.
add: Added natural thermal vision and very weak night vision to Yautja species, to fit with our wiki lore.
del: Removed Thermal and Meson visors from Yautja mask.
/:cl:

@realforest2001 realforest2001 added Whitelist Changes Testmerge Candidate we'll test this while you're asleep and the server has 10 players labels Jul 29, 2023
@github-actions github-actions bot added Fix Fix one bug, make ten more Feature Feature coder badge Removal snap labels Jul 29, 2023
code/modules/cm_preds/yaut_mask.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_mask.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_mask.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_mask.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_mask.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft August 4, 2023 05:28
@realforest2001 realforest2001 marked this pull request as ready for review August 5, 2023 17:09
code/modules/cm_preds/yaut_mask.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_mask.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_mask.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_mask.dm Outdated Show resolved Hide resolved
Copy link
Contributor

@BeagleGaming1 BeagleGaming1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code good

@BeagleGaming1 BeagleGaming1 added this pull request to the merge queue Aug 12, 2023
Merged via the queue into cmss13-devs:master with commit ae962a9 Aug 12, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Fix Fix one bug, make ten more Removal snap Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants