-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Xeno Alliances Tweaks #4053
More Xeno Alliances Tweaks #4053
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
string nitpick
Co-authored-by: harryob <[email protected]>
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems good
About the pull request
xeno_message no longer sends the message to allied hives.
All hive's alliances break on Queen's death (instead of essentially just ceasing to function).
If another hive breaks alliance with you, you break alliance with them automatically.
Some code improvements.
Explain why it's good for the game
Less confusing. I meant to add a "notify_allies" var to the proc, but I haven't found a single message that should be sent to allies.
Less confusing. Essentially all alliances already don't function if queen is dead, so this way it's just more clear for everyone.
You don't have to keep hive alliance status open all the time in case allied queen decides to betray you. Simply a QoL.
Just good
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑 ihatethisengine
add: All hive's alliances break on Queen's death.
qol: If a hive breaks an alliance with another, the second hive also breaks the alliance.
fix: xeno_message no longer sends the message to allied hives
/:cl: