Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Healer Drone Ability: Sacrifice #4055

Closed
wants to merge 31 commits into from

Conversation

ihatethisengine
Copy link
Contributor

@ihatethisengine ihatethisengine commented Jul 30, 2023

About the pull request

New healer drone skill — sacrifice. If things get really bad, the healer can instantly transfer 75% of its current health and remove all debuffs from the target, but for the great cost of the healer’s own life.

The sacrifice ability is an emergency button. You don’t have to use it, but at some point you may find that sacrifice is a right thing to do, so it’s a nice option to have. I want to emphasize that this skill is not a necessary part of the healer gameplay. You don’t have to trade your life for the life of another xeno. But you can if you are willing to.

Also healer drones gets a counter of the health it has transferred. If healer drone transfers at least 10 000 health points, it will be able to respawn after using the sacrifice ability (like acid runner after kaboom).

Explain why it's good for the game

Saving fellow xenos is the most satisfying part of healer drone’s gameplay. This ability allows to save others in really dire situations, but for the great cost. It’s still fitting, because drone already can use heal ability until it goes into crit or dies, in some situations it’s a worthy risk. Also rewards long living healer drones with the opportunity to use the ability essentially for free.

I have my doubts about this ability, not going to lie, but I'll leave it to your judgement if it's a good addition to the game.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 ihatethisengine
balance: New healer drone ability — sacrifice. Healer drone can instantly transfer 75% of its current health and remove all debuffs from the target, but for the great cost of the healer’s own life.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jul 30, 2023
@cm13live
Copy link

This pull request has been mentioned on CM-SS13. Please provide feedback here:

https://forum.cm-ss13.com/t/new-healer-drone-ability-sacrifice/3359/11

@harryob harryob marked this pull request as draft July 30, 2023 17:52
@ihatethisengine ihatethisengine marked this pull request as ready for review July 31, 2023 03:12
@ihatethisengine
Copy link
Contributor Author

As a solution to the potential issue of the healer drone rendering the SADAR AP rocket useless, I think we can just remove 1 second of the stun instead of removing it completely.

ihatethisengine and others added 2 commits July 31, 2023 15:54
@harryob harryob added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Aug 4, 2023
@ihatethisengine

This comment was marked as outdated.

@ihatethisengine

This comment was marked as outdated.

@ihatethisengine
Copy link
Contributor Author

Ok, I found a solution. Now healer just uses the version of order construction that isn't set to primary action 5 (just like queen's).

@ihatethisengine
Copy link
Contributor Author

So far I am pretty happy with the ability. I think requirement for a free respawn is high enough to not make it too easy.

Comment on lines 204 to 213
/datum/behavior_delegate/drone_healer/on_life()
if(!bound_xeno)
return
if(bound_xeno.stat == DEAD)
return
var/image/holder = bound_xeno.hud_list[PLASMA_HUD]
holder.overlays.Cut()
var/percentage_transferred = round((transferred_amount / max_transferred_amount) * 100, 10)
if(percentage_transferred)
holder.overlays += image('icons/mob/hud/hud.dmi', "xenoenergy[percentage_transferred]")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about moving this into a separate proc that triggers on modify_transferred(). But not sure if that would be better, because you can heal many times in two seconds and updating HUD every time sounds like a waste + inconsistent.

@ihatethisengine
Copy link
Contributor Author

Also thinking 10 000 requirement might be even too high. But on the other hand, the ability is quite strong, so not sure.

Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tier 1 with such a strong heal and stun removal is too powerful even for the life of the player. Plus, I don't believe this is really telegraphed hard enough. I appreciate your work but all in all I don't think this would be good.

@morrowwolf morrowwolf closed this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants