Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End game timing changes #4353

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Conversation

morrowwolf
Copy link
Member

@morrowwolf morrowwolf commented Sep 8, 2023

About the pull request

This PR:

Lowers the xeno endgame start to 55 minutes into the round.

Lowers the nuke endgame start to 115 minutes into the round.

Lowers the nuke cost to 5 points.

Explain why it's good for the game

Xenos need a bit of a boost come midgame.

Nuke should be easier to acquire once it is time to consider it and it should become available on the hour rather than 5 minutes offset due to roundstart time.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Morrow
balance: Lowered the xeno endgame start to 55 minutes into the round
balance: Lowered the nuke endgame start to 115 minutes into the round
balance: Lowered the nuke cost to 5 points
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Sep 8, 2023
Copy link
Contributor

@TheGamerdk TheGamerdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

desc = "Purchase a nuclear device. Only able to purchase [NUKE_UNLOCK_TIME / (1 MINUTES)] minutes into the operation. It's the only way to be sure."

This is going to show 115 minutes instead of 120

You should just use world.time instead of ROUND_TIME further down, to disregard the roundstart offset

@harryob harryob added this pull request to the merge queue Sep 11, 2023
Merged via the queue into cmss13-devs:master with commit ec3e08c Sep 11, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Sep 11, 2023
@morrowwolf morrowwolf deleted the end-game-timing branch September 11, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants