Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no more anchorpoint pvt #4492

Merged
merged 2 commits into from
Sep 28, 2023
Merged

no more anchorpoint pvt #4492

merged 2 commits into from
Sep 28, 2023

Conversation

QuickLode
Copy link
Contributor

@QuickLode QuickLode commented Sep 24, 2023

About the pull request

hi this mainly fixes intended timelocks for 2 vital CMB roles, and removes Pvts from Anchorpoint QRF

Had a rank/timelock error due to the way the root was set, this alleviates it so no more Pvt leading the entire squad LMAO(In hindsight I feel like a Pvt is out of place to be on a QRF being sent from anchorpoint, and instead newer troops would stay on the station, may readd later tho)
Also the intended 5hr SL timelock was placed on CMB Mar to prevent weird incidents which have happened. 1hr for ICC for CL duties.

also I'm not sure why but it seems black market CMB may be having problems with their hud? i will add it if I find a problem

Explain why it's good for the game

bug bad

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
del: removed Pvts from Anchorpoint QRF (rip)
spellcheck: fixed a typo in CMB call-in
/:cl:

@github-actions github-actions bot added Removal snap Fix Fix one bug, make ten more Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors labels Sep 24, 2023
code/game/jobs/job/special/cmb.dm Outdated Show resolved Hide resolved
@morrowwolf morrowwolf marked this pull request as draft September 27, 2023 21:39
@QuickLode QuickLode marked this pull request as ready for review September 28, 2023 00:21
@QuickLode QuickLode changed the title tiny CMB fixes no more anchorpoint pvt Sep 28, 2023
@morrowwolf morrowwolf added this pull request to the merge queue Sep 28, 2023
Merged via the queue into cmss13-devs:master with commit 0f25138 Sep 28, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors Removal snap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants