Synthetic pain sources change #4757
Conversation
QuickLode
changed the title
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
| var/datum/action/xeno_action/onclick/lurker_assassinate/ability = get_xeno_action_by_type(bound_xeno, /datum/action/xeno_action/onclick/lurker_assassinate) | ||
| if (ability && istype(ability)) | ||
| ability.button.icon_state = "template" | ||
| if(IS_SYNTHETIC) |
There was a problem hiding this comment.
aren’t you checking for a constant value? this is just a bitfield
|
Just FWIW (and I'm not a maintainer anymore so whatever) a lot of this synth specific stuff should probably just be passed to species to handle so we can OOP a bit and not have all of these if(synth) changes all over iunno |
|
I feel uncertain about this one |
About the pull request
Changes up text for pain and should removes slow from zombie
"But why do Synths feel pain when internals damaged" I have that 'fixed' in another PR where synths will get powercell failure from getting internals hurt
"But why do Synths feel pain when nearing crit" this is supposed to simulate a catastrophic chassis shutdown
"But why does the beserker rav still pain the synth?" well its a big ass scythe unlike the little rat claws or tail so I thought this is fine for now.
Explain why it's good for the game
Synthetics don't feel pain, and would not be crippled in the same way as a human would be.
Testing Photographs and Procedure
Screenshots & Videos
Wasn't able to fully test this because I only have 1 client!Changelog
🆑
fix: Synthetic's no longer feel pain from zombie claws
spellcheck: clarifies Synthetic pain during a crippling slash
/:cl: