Working Joes now Respawn (The PR respawned) #4795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ben10083
changed the title
BroseidonMOO
added
the
Testmerge Candidate
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
fira
approved these changes
Nov 11, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
# About the pull request Redo of #4429 and #4795, done after someone requested I revive the revived PR. 15 minute respawns for Working Joes, they can still be revived and still have to follow other limits such as job limits and admin locks. # Explain why it's good for the game Working Joes being able to respawn allows for a Joe player to still participate in the round as a Working Joe, even if they died as a Joe before. This should only really have an impact if the Joe died before hijack and will not be revived. # Changelog :cl: add: Working Joes can now respawn as a Working Joe after 15 minutes, previous restriction on respawn removed. admin: New flag to disable Working Joe respawns /:cl: --------- Co-authored-by: Ben10083 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Redo of #4429, done after someone requested I revive the PR, and after the blessing of the headtainer was acquired.
15 minute respawns for Working Joes, they can still be revived and still have to follow other limits such as job limits and admin locks.
Explain why it's good for the game
Working Joes being able to respawn allows for a Joe player to still participate in the round as a Working Joe, even if they died as a Joe before. This should only really have an impact if the Joe died before hijack and will not be revived.
Changelog
🆑
add: Working Joes can now respawn as a Working Joe after 15 minutes, previous restriction on respawn removed.
/:cl: