Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes for Loadout Items #4849

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Minor fixes for Loadout Items #4849

merged 3 commits into from
Nov 9, 2023

Conversation

fira
Copy link
Member

@fira fira commented Nov 5, 2023 •
edited by github-actions bot
Loading

About the pull request

Minor fixes for #4801

  • Removes hard ref in photo and pen
  • Switches post-spawn signaling to avoid recursing mob contents
  • Fix unset pen displaying bogus text
  • Add a fallback for plushie generator to put it in hands if theres no backpack
  • Fix lingering reference for map-placed random plushies

And with any luck that also fixes the photo initialization bug

Explain why it's good for the game

Is fix

Testing Photographs and Procedure

Just tested spawning in with plushie / photo a few times

@fira fira added the Fix Fix one bug, make ten more label Nov 5, 2023
@harryob harryob added this pull request to the merge queue Nov 9, 2023
Merged via the queue into cmss13-devs:master with commit d120fa7 Nov 9, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harryob harryob harryob approved these changes

Assignees
No one assigned
Labels
Fix Fix one bug, make ten more
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fira @harryob