/tg/ Status Effects Prelude D - Mob Freeze Refactor #4878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
removed
the
Merge Conflict
harryob
approved these changes
Nov 13, 2023
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
added
the
Merge Conflict
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Another bit split off #4828 - this implements TRAIT_IMMOBILIZED partially by using it to replace freeze functionality. It does not include all the interactions with other traits because they're not yet in this version.
Explain why it's good for the game
Stops issues with freeze getting stuck thanks to Trait magic.
Also a mandatory passage point toward removing update_canmove in Part 1 PR
Testing Photographs and Procedure
Tested Admin Panel Freeze/Unfreeze, that they were updated timely and not on Lifetick, Runner pounce, and interaction of both of them
Changelog
🆑
fix: Rooting effects should now properly update when stacked and unstacked.
/:cl: