Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kills var/burrow replaces with trait #4893

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

Birdtalon
Copy link
Contributor

@Birdtalon Birdtalon commented Nov 10, 2023

About the pull request

Replaces var/burrow with TRAIT_ABILITY_BURROWED

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
code: Replaces burrow var from Xenomorph with burrowed trait
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Nov 10, 2023
@fira
Copy link
Member

fira commented Nov 11, 2023

Changelog!!!!!!!!!!

Also don't forget to remove the actual variable :clueless:

Copy link
Contributor

@Diegoflores31 Diegoflores31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remember that you shall change all single letter vars 🤓 example: X > xeno or M -> morbius

@Birdtalon
Copy link
Contributor Author

Birdtalon commented Nov 11, 2023

Also remember that you shall change all single letter vars 🤓 example: X > xeno or M -> morbius

That is outside the scope of this PR and changing some variable names will make this much larger since those are referenced later in the code also. I do intend to work through xeno-code and do this later though.

@fira
Copy link
Member

fira commented Nov 11, 2023

Changelog entry for refactor is code: now i think

@Birdtalon Birdtalon marked this pull request as ready for review November 11, 2023 11:44
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactor prs?? in my cm? unbelievable

@harryob harryob added this pull request to the merge queue Nov 13, 2023
Merged via the queue into cmss13-devs:master with commit f3051bc Nov 13, 2023
29 checks passed
cm13-github added a commit that referenced this pull request Nov 13, 2023
@Birdtalon Birdtalon deleted the burrow branch December 21, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants