Fixes list for the vehicle computer. [NO GAMEPLAY EFFECT] #4902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you're missing the parenthesis () |
|
I'm stupid. That's fixed now. |
Birdtalon
reviewed
Nov 17, 2023
Comment on lines
+1334
to
+1336
| new /datum/vehicle_order/apc(), | ||
| new /datum/vehicle_order/apc/med(), | ||
| new /datum/vehicle_order/apc/cmd(), |
There was a problem hiding this comment.
If you instantiate these here it can't also be done again below as this causes runtimes on mapload.
cmss13/code/game/supplyshuttle.dm
Lines 1339 to 1340 in a17e6a5
|
exactly what birdtalon said, but also, fira's pr (which was made after this one, my bad) also fixes this and was already merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparentally the vehicle ordering computer wouldn't work even if one attempted to set spent = TRUE. This was due to the datums in the vehicles list not properly set up.
Explain why it's good for the game
Helps staff spawn vehicles through the consoles, the OG way, instead of spawning stuff individually.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
admin: Fixes vehicle list for the vehicle ASRS computer.
/:cl: