Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfixes accidental early update_canmove removal #4915

Closed
wants to merge 1 commit into from

Conversation

fira
Copy link
Member

@fira fira commented Nov 13, 2023

About the pull request

Yes, another hotfix, i love merge conflict resolution

Readd update_canmove() calls that went missing on #4885 when this was meant for a further stage of status PRs

This causes stuns not to apply immediately with our current system

🆑
fix: Fixed stuns/knockdowns/knockdouts not applying timely anymore.
/:cl:

@fira fira added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Nov 13, 2023
@github-actions github-actions bot added the Fix Fix one bug, make ten more label Nov 13, 2023
@fira fira changed the title Fix accidental early update_canmove removal Hotfixex accidental early update_canmove removal Nov 13, 2023
@fira fira changed the title Hotfixex accidental early update_canmove removal Hotfixes accidental early update_canmove removal Nov 13, 2023
@Teragenic Teragenic mentioned this pull request Nov 17, 2023
3 tasks
@fighterslam fighterslam mentioned this pull request Nov 20, 2023
3 tasks
@fira fira added Do Not Merge If you merge this PR, I will annihilate you and removed Testmerge Candidate we'll test this while you're asleep and the server has 10 players labels Nov 21, 2023
@fira
Copy link
Member Author

fira commented Nov 21, 2023

Superseded by #4828 - don't testmerge both at same time, compile WILL fail

@fira fira removed the Do Not Merge If you merge this PR, I will annihilate you label Nov 27, 2023
@fira fira closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants