Refactors vendor global scope procs #4918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fira
approved these changes
Nov 13, 2023
harryob
requested changes
Nov 16, 2023
| @@ -443,7 +443,7 @@ GLOBAL_LIST_EMPTY(vending_products) | |||
| //------------TGUI PROCS--------------- | |||
|
|
|||
| /obj/structure/machinery/cm_vending/ui_data(mob/user) | |||
| return vendor_user_ui_data(src, user) | |||
| return vendor_user_ui_data(user) | |||
There was a problem hiding this comment.
oh wait this proc should just return what vendor_user_ui_data and we should get rid of that proc if it's not used anywhere else
harryob
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Refactors awful vendor global scope procs.
Really this entire file needs looking at why do vending machines need 1300 lines. This is a start at least.
Also removed a bunch of commented out code at the bottom.
Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
code: Refactors vending machine global scope procs
/:cl: