Lurker: bug fix, var disambiguation and redundant type checks #4922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Fix
Birdtalon
commented
Nov 13, 2023
| @@ -84,7 +84,7 @@ | |||
| target_carbon.set_effect(get_xeno_stun_duration(target_carbon, 3), SUPERSLOW) | |||
| next_slash_buffed = FALSE | |||
| var/datum/action/xeno_action/onclick/lurker_assassinate/ability = get_xeno_action_by_type(bound_xeno, /datum/action/xeno_action/onclick/lurker_assassinate) | |||
| if (ability && istype(ability)) | |||
There was a problem hiding this comment.
This is already typechecked in get_xeno_action_by_type() so this should be redundant.
cmss13/code/modules/mob/living/carbon/xenomorph/abilities/xeno_action.dm
Lines 367 to 374 in 66e9557
harryob
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: Lurker can no longer tail jab through doors/structures.
code: Var disambiguation, cleanup and removal of redundant typechecks in lurker code.
/:cl: