Fixes some Almayer Walls randomly changing icons when hit #4936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Horizontal Almayer walls have "decoration" variants that are placed randomly. Because these are applied in update_icon randomly, if you shoot such a wall, it will cycle randomly through available icons.
On top of that, because the replacement icon was applied as an overlay, it was drawn over everything else masking bullet and damage overlays.
This fixes both issues by making it use the icon instead and rolling decorations ahead of time.
Explain why it's good for the game
Consistency. Awfully distracting if you're in the firing range too
Changelog
🆑
fix: Horizontal Almayer walls no longer change icon randomly, and now properly display damage overlays.
/:cl: