Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent LZ names. #5079

Merged
merged 10 commits into from
Dec 2, 2023
Merged

Conversation

blackdragonTOW
Copy link
Contributor

About the pull request

Alters the lz1/lz2 names of each map placed object to have LZ1 or LZ2 in the front of the name, that way there's never any confusion over which is which when looking at the DS consoles. "We're going to LZ2" should never be a point of confusion for new POs anymore.

Explain why it's good for the game

Information good.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
maptweak: Standardized the names of LZs to include the name of the LZ.
/:cl:

@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Nov 30, 2023
@HeresKozmos
Copy link
Contributor

Pretty based

@fira
Copy link
Member

fira commented Nov 30, 2023

Well i'd argue this makes the "Landing Zone" in the name redundant

@BadAtThisGame302
Copy link
Contributor

Shouldn't it be consistent the other way around? Like removing the LZ1-2 indicators and focusing more on the Landing Zone location and title?

@blackdragonTOW
Copy link
Contributor Author

The name edits will only show up in the dropship console and remote consoles, having good flavor names is nice but if the pilot doesnt know which is LZ1 and which is LZ2 it can lead to confusion.

If the lz1 or lz2 objects are not assigned a custom name, they default to Landing Zone 1, or Landing Zone 2, respectively. Hence why the only changes here are for LZs that have custom names.

Here is a direct example of what I mean:
Capture

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Dec 1, 2023
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Nanu308 Nanu308 added this pull request to the merge queue Dec 2, 2023
Merged via the queue into cmss13-devs:master with commit 3a2cd5a Dec 2, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants