Fix runtimes and multitool bricking if a sentry_computer is deleted #5345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mullenpaul
approved these changes
Dec 30, 2023
realforest2001
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR resolves some runtimes and the bricking of a multitool if it is loaded with a deleted sentry. The weakref resolve in the multitool wasn't checked if the resolve passed. Additionally, the sentries would remain encrypted to a non-existent computer. If bricking an encrypted sentry is intended, it needs to be handled more gracefully.
Explain why it's good for the game
Fixes a runtime when using a multitool linked to a deleted sentry_computer:
Fixes a runtime when using said multitool to unpair the sentry from a deleted sentry_computer.
Testing Photographs and Procedure
Screenshots & Videos
Untitled.mp4
Changelog
🆑 Drathek
fix: Fix handling of sentry_computer deletion
/:cl: