Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds warning messages when CAS sonic boom happens and makes the boom fallof slower #5410

Merged
merged 33 commits into from
Jan 25, 2024

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Jan 9, 2024

About the pull request

adds more warnings to aproaching cas

Explain why it's good for the game

gives xenos even more clues about incoming firemission, should prevent silent cas unless you are runner who runs in straight form the other sife of map directly into FM

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: added messages when the CAS sonic boom is played
soundadd: reduced volume falloff of CAS sonic boom
/:cl:

@cuberound cuberound requested a review from fira as a code owner January 9, 2024 16:41
@cuberound cuberound marked this pull request as draft January 9, 2024 16:41
@github-actions github-actions bot added the Feature Feature coder badge label Jan 9, 2024
@cuberound cuberound marked this pull request as ready for review January 11, 2024 10:40
Copy link
Member

@SabreML SabreML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

code/game/cas_manager/datums/cas_fire_envelope.dm Outdated Show resolved Hide resolved
code/game/cas_manager/datums/cas_fire_envelope.dm Outdated Show resolved Hide resolved
code/game/cas_manager/datums/cas_fire_envelope.dm Outdated Show resolved Hide resolved
code/game/cas_manager/datums/cas_fire_envelope.dm Outdated Show resolved Hide resolved
code/game/cas_manager/datums/cas_fire_envelope.dm Outdated Show resolved Hide resolved
code/game/cas_manager/datums/cas_fire_mission.dm Outdated Show resolved Hide resolved
code/game/cas_manager/datums/cas_fire_mission.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft January 18, 2024 16:01
code/game/cas_manager/datums/cas_fire_mission.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft January 20, 2024 13:21
@cuberound cuberound marked this pull request as ready for review January 21, 2024 09:04
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code works but uh, good luck ever hitting anything with CAS ever again.

Untitled.mp4
  1. Remove the positional information from your new message.
  2. Increase this sleep to maybe 1.5 SECONDS:
	// Xenos have time to react to the first message
	sleep(0.5 SECONDS)

But take into consideration this may have other consequences e.g. QDEL_IN(firemission_effect, 5 SECONDS) may have to be longer.

@Drulikar Drulikar marked this pull request as draft January 23, 2024 10:19
@cuberound cuberound marked this pull request as ready for review January 23, 2024 14:56
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise this seems workable.

CAS.mp4

code/game/cas_manager/datums/cas_fire_envelope.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar dismissed harryob’s stale review January 25, 2024 23:40

Requested changes were made

@Drulikar Drulikar added this pull request to the merge queue Jan 25, 2024
Merged via the queue into cmss13-devs:master with commit 9cb7ac7 Jan 25, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants