Resolve sticky messages in STUI #5581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
UI
harryob
approved these changes
Jan 29, 2024
cm13-github
added a commit
that referenced
this pull request
Jan 29, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
# About the pull request Fixes the search function of `tgui_input_list`, and also makes the search bar automatically focus when toggled. This was caused by the same issue as #5581. # Explain why it's good for the game Bugfix, and a little QOL thing. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> ('Teleport to Area' menu as an example, but it's the same on any others.) **Before:** https://github.com/cmss13-devs/cmss13/assets/57483089/8450adef-38f4-4ae4-963a-11533a328841 **After:** https://github.com/cmss13-devs/cmss13/assets/57483089/ede80ffa-7ce6-47c9-9711-a5f29560d1bd </details> # Changelog :cl: fix: Fixed the search function of TGUI input lists. qol: Made the TGUI input list search bar automatically focus when toggled. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixed the issue for STUI locally. The issue appears have happened because infernojs and react deal with key management on iterators differently. By using the index for the iterator, rather than the entire log message, this seems to have resolved it.
Explain why it's good for the game
Resolves #5557
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
code: fixes sticky messages in STUI
refactor: STUI is now a TSX component
/:cl: