-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto Delete Foodless MREs #5761
Conversation
code/game/machinery/vending/vendor_types/squad_prep/squad_prep.dm
Outdated
Show resolved
Hide resolved
Whilst I think removing the fluff items from all MREs would completely remove the FOB clutter issue, however I cannot discount the chance some people may use the fluff items in the MREs ergo I've elected to keep the standard issue MRE's the default ones. |
An idea I had a while ago was a sort of mid-way sprite when only fluff items remain in an MRE. That or the regular crushed up sprite being visible when only fluff items remain. I believe this would solve the issue without dialing back the amount of fluff items that are available to more roleplay-centered marines (or those who just like the free smokes (virtual nic addicts)). I, along with a handful of other people, do enjoy the fluff items included in MREs, but I still think FOB clutter is insanely exponentialized by non-crushed up (basically useless) MREs. Though I do want to have the ability to pick out these fluff items at liberty of my own will, be they from MREs strewn along the ground or one that I dropped with. |
I don't think we should remove fluff items, instead, just add a option for one to crumple the MRE pack even if it contains the fluff items |
The issue with that @Nanu308 is that it would need to be automated as literally no one is going to crumple their MRE manually. Making it a automatic action is beyond my abilities |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Try adding this to
Your diff should look like this: What this code does is when the package gets dropped, it checks for whether it still has food in it. If it does, nothing happens. If it has none, it closes the interface and deletes the MRE. |
Try above, that sounds fine. |
I'll get to this sometime next week |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Altered PR to suggested comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also technically you can open it, drop it with food, remove the food, and then it won't be deleted; but not a big deal. Just figured I'd mention it.
Co-authored-by: Drathek <[email protected]>
# About the pull request Deletes empty pill packets (the 4 pill packets) when dropped and empty. Used code from: #5761 # Explain why it's good for the game has less pointless garbage on the ground. they can't be refilled anyway. # Testing Photographs and Procedure emptied pill packets and a pill bottle. verified pill packet only deleted when dropped or thrown. Pill bottles persisted. Packets persisted so long as remained in inventory. IE put into another pouch. <details> https://github.com/user-attachments/assets/1736dedd-4c22-4d7a-9957-29361c320d45 </details> # Changelog :cl: qol: Deletes empty pill packets when dropped. /:cl:
About the pull request
MRE's that contain no food will now be automatically deleted.
Explain why it's good for the game
Current MRE's mean the FOB, and frontline where a resupply crate lands, are littered with endless amounts of opened MRE's that are filled with the fluff items. This not only clutters up the area but it means if you are desperate for food, you have to search these half-used MRE's.
With this change, this means that a MRE on the ground will actually contain food instead of matches or water, and this will significantly declutter the FOB and frontline of food items.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
add: MRE's will now auto-delete if they do not contain and food items when they are discarded.
/:cl: