Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime since HAS_TRAIT doesn't null test #5811

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Feb 25, 2024

About the pull request

This PR is a follow up to #5795 fixing a runtime should you swap to an empty hand during welding. This should be caught if we used INTERRUPT_ALL instead of INTERRUPT_NO_NEEDHAND but maybe multitasking something else like wire maybe was intended.

Explain why it's good for the game

Fixes
image

Testing Photographs and Procedure

Screenshots & Videos
weld.mp4

Changelog

🆑 Drathek
fix: Fixed a runtime when swapping tools during cade welding
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Feb 25, 2024
@Drulikar Drulikar changed the title FIx runtime since HAS_TRAIT doesn't null test Fix runtime since HAS_TRAIT doesn't null test Feb 26, 2024
@SabreML SabreML added this pull request to the merge queue Feb 26, 2024
Merged via the queue into cmss13-devs:master with commit d88ed23 Feb 26, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Feb 26, 2024
@Drulikar Drulikar deleted the Fix_Cade_Weld_Runtime branch February 28, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants