Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes trapper fire damage #6310

Closed
wants to merge 2 commits into from

Conversation

Git-Nivrak
Copy link
Contributor

@Git-Nivrak Git-Nivrak commented May 19, 2024

About the pull request

Globber PR featured an increased fire damage multiplier but forgot to account for the trapper strain

Explain why it's good for the game

Oversights \ bugs are bad, fix good

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: Trapper no longer takes triple fire damage
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label May 19, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label May 27, 2024
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label May 30, 2024
Copy link
Contributor

github-actions bot commented Jun 7, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 7, 2024
@Drulikar Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels Jun 7, 2024
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work as intended. This extends the lifespan of an on-fire trapper about 2x that of a regular boiler. Trapper and regular strain should both last the same amount of time on fire.

@Zonespace27 Zonespace27 marked this pull request as draft June 12, 2024 10:19
@Drulikar
Copy link
Contributor

I'm not sure what Zonespace saw needing changes; but I don't think Trapper strain is intended to have a perk of fire resistance (at least compared to the caste the strain modified). Trapper probably needs something to make it more interesting, but I don't think this is it, nor do I think it needs this at least right now.

@Drulikar Drulikar closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Stale Exempt PR can't go stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants