Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a HUD icon for crit marines for vampire lurker #6314

Merged
merged 13 commits into from
Jun 19, 2024

Conversation

Git-Nivrak
Copy link
Contributor

@Git-Nivrak Git-Nivrak commented May 20, 2024

About the pull request

Adds an HUD icon for marines that can be headbited for vampire
This was comically complicated to add

Explain why it's good for the game

Rather than having to spam headbite 20 times until someone is actually unconcious, adds a neat HUD icon.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
qol: Added an hud icon for vampires that lets them know when an enemy can be executed.
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label May 20, 2024
@Diegoflores31
Copy link
Contributor

xased

@neeshacark
Copy link
Contributor

vampire lurkers really don't need more handholding, they are already objectively the strongest t2

code/datums/effects/xeno_strains/execute_tag.dm Outdated Show resolved Hide resolved
code/datums/effects/xeno_strains/execute_tag.dm Outdated Show resolved Hide resolved
code/datums/effects/xeno_strains/execute_tag.dm Outdated Show resolved Hide resolved
code/datums/effects/xeno_strains/execute_tag.dm Outdated Show resolved Hide resolved
code/datums/effects/xeno_strains/execute_tag.dm Outdated Show resolved Hide resolved
code/datums/effects/xeno_strains/execute_tag.dm Outdated Show resolved Hide resolved
code/datums/effects/xeno_strains/execute_tag.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/human/life.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft May 24, 2024 12:49
@Git-Nivrak Git-Nivrak marked this pull request as ready for review May 24, 2024 13:17
Copy link
Contributor

github-actions bot commented Jun 1, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 1, 2024
@Drulikar Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels Jun 7, 2024
@Drulikar
Copy link
Contributor

Drulikar commented Jun 7, 2024

Stale exempt until reviewed again.

harryob
harryob previously requested changes Jun 7, 2024
code/modules/mob/living/carbon/human/life.dm Outdated Show resolved Hide resolved
@Git-Nivrak Git-Nivrak requested a review from harryob June 7, 2024 12:49
code/modules/mob/living/carbon/human/life.dm Outdated Show resolved Hide resolved
code/datums/effects/xeno_strains/execute_tag.dm Outdated Show resolved Hide resolved
code/datums/effects/xeno_strains/execute_tag.dm Outdated Show resolved Hide resolved
code/datums/effects/xeno_strains/execute_tag.dm Outdated Show resolved Hide resolved
code/datums/effects/xeno_strains/execute_tag.dm Outdated Show resolved Hide resolved
code/datums/effects/xeno_strains/execute_tag.dm Outdated Show resolved Hide resolved
code/datums/effects/xeno_strains/execute_tag.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft June 19, 2024 07:47
@Drulikar Drulikar removed the Stale Exempt PR can't go stale label Jun 19, 2024
@Git-Nivrak Git-Nivrak marked this pull request as ready for review June 19, 2024 20:16
@Drulikar Drulikar enabled auto-merge June 19, 2024 20:35
@Drulikar Drulikar added this pull request to the merge queue Jun 19, 2024
Merged via the queue into cmss13-devs:master with commit 6ff388b Jun 19, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants