Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tank IFF, Minigun tweaks, code cleanup & new hitsound #6688

Merged
merged 13 commits into from
Aug 23, 2024

Conversation

TheManWithNoHands
Copy link
Contributor

@TheManWithNoHands TheManWithNoHands commented Jul 11, 2024

About the pull request

  • Adds IFF to the Minigun
  • Changes used projectile icon for Minigun
  • Adds scatter decrease to Minigun with windup
  • increases firing speed of the minigun
  • increases rev up time of the minigun
  • Puts Minigun bullet code into the tank ammo file, for organisation.
  • Adds hitsound for Autocannon Flakbullets
  • Adds new projectile icon for Autocannon
  • Fixes code for UPP minigun ammo

Explain why it's good for the game

The Minigun for the Tank is lacking IFF for no good reason. Its a left over from old code and isnt adjusted for its current state.
This should make the Minigun less ass to use, and also make the Minigun a better choice overall.
The autocannon keeps FF, to have to role of a more high risk/high damage weapon. Its semi automatic, so it can affort not getting IFF.

The Minigun also gets thigther spread as it spins up. It starts at a higher spread in turn.
The full time to achive full spin has also been increased by 2 seconds, and the overall firingspeed has been very very sligthly increased.
This overall should make the minigun a very good support weapon. Baiscly the SGs bigger cousin, just that the gun is actually fun. I hope. to eleate it being the SGs bigger cousin, the gun now no longer has smaller projectile sprites then the SG. Autocannon also gets new sprites fitting for its 20mm rounds.
These changes should elevate the minigun to become a more stable pick and less of a noob trap.

The new hitsound is sampeld straigth from pixabay or our repo. So no legal troubles there.

Thanks to cuberound that helped with the minigun scatter code

Testing Photographs and Procedure

Screenshots & Videos ![grafik](https://github.com/user-attachments/assets/ebca5e74-6a3e-4e35-a288-613e550d094b)

Changelog

🆑 TheManWithNoHands
balance: IFF, scatter based on minigun rev up, rev up time increase, firing delay decrease
code: Places minigun aMmo in the Tank ammo File
soundadd: adds a hit sound for 20mm flak
/:cl:

@github-actions github-actions bot added Sound Blast 5 minutes of bass boosted music to our players Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer labels Jul 11, 2024
@TheManWithNoHands TheManWithNoHands changed the title Autocannon & Minigun IFF, code cleanup, new sounds Tank IFF, Minigun tweaks, cleanup & new hitsound Jul 11, 2024
@TheManWithNoHands TheManWithNoHands changed the title Tank IFF, Minigun tweaks, cleanup & new hitsound Tank IFF, Minigun tweaks, code cleanup & new hitsound Jul 11, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 23, 2024
@Drulikar Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels Jul 29, 2024
@Drulikar
Copy link
Contributor

stale exempt until reviewed

kiVts
kiVts previously requested changes Aug 17, 2024
code/datums/ammo/bullet/tank.dm Show resolved Hide resolved
code/datums/ammo/bullet/tank.dm Outdated Show resolved Hide resolved
@kiVts kiVts marked this pull request as draft August 17, 2024 23:40
@TheManWithNoHands
Copy link
Contributor Author

How the hell did i start a review by answering someone.

@github-actions github-actions bot added the Sprites Remove the soul from the game. label Aug 22, 2024
@TheManWithNoHands TheManWithNoHands marked this pull request as ready for review August 23, 2024 01:16
@Blundir Blundir added the Sprites Approved confirmed no stray pixels label Aug 23, 2024
code/datums/ammo/bullet/tank.dm Outdated Show resolved Hide resolved
@harryob harryob enabled auto-merge August 23, 2024 12:55
@harryob harryob added this pull request to the merge queue Aug 23, 2024
Merged via the queue into cmss13-devs:master with commit ba5c7ca Aug 23, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Aug 23, 2024
@TheManWithNoHands TheManWithNoHands deleted the autocannon-fixes branch August 24, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer Sound Blast 5 minutes of bass boosted music to our players Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game. Stale Exempt PR can't go stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants