Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gravity generator removal #6751

Merged
merged 7 commits into from
Aug 9, 2024
Merged

Gravity generator removal #6751

merged 7 commits into from
Aug 9, 2024

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Jul 18, 2024 •
edited by github-actions bot
Loading

About the pull request

not used and super ugly old ss13 sprites that should not be used on maps

Explain why it's good for the game

less legacy mess

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
del: removes gravity generator (ugly legacy stuff)
/:cl:

@cuberound cuberound requested a review from Nanu308 as a code owner July 18, 2024 09:13
@github-actions github-actions bot added Mapping did you remember to save in tgm format? Removal snap labels Jul 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 26, 2024
Nanu308
Nanu308 requested changes Jul 28, 2024
View reviewed changes
maps/map_files/CORSAT/Corsat.dmm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a replacement sprite of some sort first, otherwise it just looks really weird.

@Nanu308 Nanu308 marked this pull request as draft July 28, 2024 13:33
@Nanu308 Nanu308 removed the Stale beg a maintainer to review your PR label Jul 28, 2024
@cuberound cuberound marked this pull request as ready for review July 28, 2024 14:18
@cuberound cuberound requested a review from Nanu308 August 5, 2024 16:38
Nanu308
Nanu308 reviewed Aug 9, 2024
View reviewed changes
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Aug 9, 2024
Nanu308
Nanu308 approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

g

@Nanu308 Nanu308 added this pull request to the merge queue Aug 9, 2024
Merged via the queue into cmss13-devs:master with commit 6504815 Aug 9, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Aug 9, 2024
@cm13-github
Automatic changelog for PR #6751 [ci skip]
03bb2bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nanu308 Nanu308 Nanu308 approved these changes

Assignees
No one assigned
Labels
Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Removal snap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cuberound @Nanu308 @uuuuhuuuu