Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch PB bonus projectile knockback #6784

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Doubleumc
Copy link
Contributor

@Doubleumc Doubleumc commented Jul 23, 2024

About the pull request

Prevents an issue with PB bonus projectiles.

In a PB, the initial projectile is never "fired", it remains in nullspace. That's fine, since there's special handling in knockback code for a projectile in nullspace, it uses the firer.

In a PB, bonus projectiles are set to the target's loc. That doesn't matter much except for knockback, which uses the position of the projectile vs. the position of the target. The bonus projectile is on the same tile as the target, so it can't give a sane angle, so it defaults to EAST.

This changes the bonus projectile's position to nullspace, matching how the initial projectile works.

Explain why it's good for the game

If a bonus projectile with knockback were ever to be used, this will prevent issues.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

No player facing changes.

@github-actions github-actions bot added the Missing Changelog Maintainers always document their changes. label Jul 23, 2024
@Zonespace27 Zonespace27 linked an issue Jul 24, 2024 that may be closed by this pull request
@Zonespace27 Zonespace27 removed a link to an issue Jul 24, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 31, 2024
@harryob harryob added this pull request to the merge queue Aug 23, 2024
Merged via the queue into cmss13-devs:master with commit 97c21f9 Aug 23, 2024
28 checks passed
@Doubleumc Doubleumc deleted the patch-bonus-projectiles-loc branch August 23, 2024 18:28
@Doubleumc Doubleumc mentioned this pull request Aug 26, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing Changelog Maintainers always document their changes. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants